Power By 专否社区

Is there anyway to simplify this IBOutletConnection statement?

Go To StackoverFlow.com

2

Is there any way to simplify this method? Perhaps a way to && both statements together in one for- loop?

// Enable valid decimal buttons
- (IBAction)enableDecimalValues 
{
    for(UIButton *decimalButton in nonOctalValueCollection)
    {
        decimalButton.enabled = YES;
        [decimalButton setAlpha:1];
    }

    for(UIButton *decimalButton in nonBinaryValueCollection)
    {
        decimalButton.enabled = YES;
        [decimalButton setAlpha:1];
    }
}
2012-04-04 20:53
by Joey
Just a side note it can be a bit odd to see a mixture of dot and bracketed notation right next to each other (being consistant is much easier to work with) in this case it would be cleaner to pick one - Paul.s 2012-04-04 21:45

4

There is nothing "wrong" with your code, per se. What you have here is clarity; a reader can quickly see and understand what is happening.

Alternatives require allocating memory and copying objects, just so you can have 1 loop. But in the end, the performance is worse (strictly speaking).

But, if you insist, how about this:

NSMutableArray *buttons = [[[NSMutableArray alloc] initWithArray:nonOctalValueCollection] autorelease];
[buttons addObjectsFromArray:nonBinaryValueCollection];

for(UIButton *decimalButton in buttons)
{
    decimalButton.enabled = YES;
    [decimalButton setAlpha:1];
}

(Leave off the autorelease if you're using ARC.)

2012-04-04 20:58
by Mark Granoff
well done, this works perfectly. thank yo - Joey 2012-04-04 21:05

4

It seems to me that you are trying to make it DRY and the bit that is repeated is what is happening in the body of the loop. I don't see the need to allocate a new array just so you only have to iterate over one collection so I would do something like this

void (^block)(UIButton *button, NSUInteger idx, BOOL *stop) = 
^(UIButton *button, NSUInteger idx, BOOL *stop) {
    button.enabled = YES;
    button.alpha   = 1.0f;
};

[nonOctalValueCollection  enumerateObjectsUsingBlock:block];
[nonBinaryValueCollection enumerateObjectsUsingBlock:block];

This DRY's it up and does not incur the additional allocation of the temporary array.

2012-04-04 21:18
by Paul.s

2

Think this is the most simple you can make it. Alternatively you could refactor the code to another method and pass both arrays to this method.

NSMutableArray *allButtons = [NSMutableArray array];
[allButtons addObjectsFromArray:nonOctalValueCollection];    
[allButtons addObjectsFromArray:nonBinaryValueCollection];

for (UIButton *button in allButtons) {
    button.enabled = YES;
    button.alpha = 1;
}
2012-04-04 20:59
by Sam

1

How about:

- (IBAction)enableDecimalValues 
{
    NSArray *combinedArray =
                [nonOctalValueCollection
                       arrayByAddingObjectsFromArray:nonBinaryValueCollection];

    [combinedArray makeObjectsPerformSelector:@selector(setEnabled:)
                                   withObject:[NSNumber numberWithBool:YES]];

    [combinedArray makeObjectsPerformSelector:@selector(setAlpha:)
                                   withObject:[NSNumber numberWithFloat:1.0f]];
}

Or:

- (IBAction)enableDecimalValues 
{
    NSArray *combinedArray =
                [nonOctalValueCollection
                       arrayByAddingObjectsFromArray:nonBinaryValueCollection];

    [combinedArray enumerateObjectsUsingBlock:
         ^(UIButton *button, NSUInteger idx, BOOL *stop)
         {
              button.enabled = YES;
              button.alpha = 1.0f;
         }];
}

Leading to:

- (IBAction)enableDecimalValues 
{
    [[nonOctalValueCollection
           arrayByAddingObjectsFromArray:nonBinaryValueCollection]
                enumerateObjectsUsingBlock:
                     ^(UIButton *button, NSUInteger idx, BOOL *stop)
                     {
                          button.enabled = YES;
                          button.alpha = 1.0f;
                     }];
}
2012-04-04 21:08
by Tommy
Ads